test(docs): fail docs build when SSR errors are detected - #23201
Open
btea wants to merge 3 commits into
Open
Conversation
Vue SSR silently swallows component render errors via handleError (console.warn), so vitepress build exits 0 even when pages are broken. This caused the voidzero/vitepress-alpha.19 incompatibility to go unnoticed. Add a wrapper script that greps the build output for SSR errors and exits non-zero if any are found.
Member
|
I think this should be fixed on the vitepress side. |
Contributor
Author
|
Okay, I'll apply a patch first to verify the process. https://github.com/vitejs/vite/actions/runs/31999117019/job/95296015095?pr=23201 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vue SSR silently swallows component render errors via handleError (console.warn), so vitepress build exits 0 even when pages are broken. This caused the voidzero/vitepress-alpha.19 incompatibility to go unnoticed. Add a wrapper script that greps the build output for SSR errors and exits non-zero if any are found.
The current CI failure is reasonable; it will only pass normally after #23199 is merged or
@voidzero-dev/vitepress-themeis fixed and updated.